| commit | c476ff1b4e7e592d6c7df19c206011711f5e1f3b | |
| author | Stefan Becker <stefan.becker@nokia.com> | |
| Mon, 14 Jun 2010 14:13:25 +0000 (14 17:13 +0300) | ||
| committer | Stefan Becker <stefan.becker@nokia.com> | |
| Mon, 14 Jun 2010 14:13:25 +0000 (14 17:13 +0300) | ||
| tree | def33f0a1841327c7561ab0766e6e775942eabbe | treesnapshot (tar.gz zip) |
| parent | 486702f6feeb32a76292834f0df37462331be57c | commitdiff |
Fix broken sipe_ht_equals_nick()
In commit 99cd5c6ab1c4fe3007d3a4603dadad905359ae75 I replaced purple util.h
functions for the core cleanup. Unfortunately there was a typo in the hash
table string compare function which caused only the second string to be
compared to itself, i.e. the function always returned TRUE. This of course
causes havoc for the hash table functionality.
The broken hash table functionality was noticed by a RHEL5 user. On that
platform the hash bucket size seems to be smaller and thus the broken
broken behaviour more likely.
The broken code has been in the 1.10.0 release. As it affects the buddy list
it could be the root cause for some of the "buddy appears offline" reports.
In commit 99cd5c6ab1c4fe3007d3a4603dadad905359ae75 I replaced purple util.h
functions for the core cleanup. Unfortunately there was a typo in the hash
table string compare function which caused only the second string to be
compared to itself, i.e. the function always returned TRUE. This of course
causes havoc for the hash table functionality.
The broken hash table functionality was noticed by a RHEL5 user. On that
platform the hash bucket size seems to be smaller and thus the broken
broken behaviour more likely.
The broken code has been in the 1.10.0 release. As it affects the buddy list
it could be the root cause for some of the "buddy appears offline" reports.
| src/core/sipe.c | diffblobblamehistory |