From 2ea3b0b68af9d5e9fe6ac648ef78e482faa54e6b Mon Sep 17 00:00:00 2001 From: Christophe Rhodes Date: Fri, 21 Feb 2014 21:53:59 +0000 Subject: [PATCH] sxhash on LAYOUT objects can use the CLOS-HASH slot ... dunno yet if it actually makes a difference in my use case's timings --- src/code/target-sxhash.lisp | 55 ++++++++++++++++++++++++++------------------- 1 file changed, 32 insertions(+), 23 deletions(-) diff --git a/src/code/target-sxhash.lisp b/src/code/target-sxhash.lisp index 9938b72a6..83a6429ce 100644 --- a/src/code/target-sxhash.lisp +++ b/src/code/target-sxhash.lisp @@ -175,34 +175,43 @@ ;; answer. -- CSR, 2004-07-14 (list (if (null x) - (sxhash x) ; through DEFTRANSFORM + (sxhash x) ; through DEFTRANSFORM (if (plusp depthoid) (mix (sxhash-recurse (car x) (1- depthoid)) (sxhash-recurse (cdr x) (1- depthoid))) 261835505))) (instance - (if (pathnamep x) - ;; Pathnames are EQUAL if all the components are EQUAL, so - ;; we hash all of the components of a pathname together. - (let ((hash (sxhash-recurse (pathname-host x) depthoid))) - (mixf hash (sxhash-recurse (pathname-device x) depthoid)) - (mixf hash (sxhash-recurse (pathname-directory x) depthoid)) - (mixf hash (sxhash-recurse (pathname-name x) depthoid)) - (mixf hash (sxhash-recurse (pathname-type x) depthoid)) - ;; Hash :NEWEST the same as NIL because EQUAL for - ;; pathnames assumes that :newest and nil are equal. - (let ((version (%pathname-version x))) - (mixf hash (sxhash-recurse (if (eq version :newest) - nil - version) - depthoid)))) - (if (or (typep x 'structure-object) (typep x 'condition)) - (logxor 422371266 - (sxhash ; through DEFTRANSFORM - (classoid-name - (layout-classoid (%instance-layout x))))) - (sxhash-instance x)))) - (symbol (sxhash x)) ; through DEFTRANSFORM + (typecase x + (pathname + ;; Pathnames are EQUAL if all the components are EQUAL, so + ;; we hash all of the components of a pathname together. + (let ((hash (sxhash-recurse (pathname-host x) depthoid))) + (mixf hash (sxhash-recurse (pathname-device x) depthoid)) + (mixf hash (sxhash-recurse (pathname-directory x) depthoid)) + (mixf hash (sxhash-recurse (pathname-name x) depthoid)) + (mixf hash (sxhash-recurse (pathname-type x) depthoid)) + ;; Hash :NEWEST the same as NIL because EQUAL for + ;; pathnames assumes that :newest and nil are equal. + (let ((version (%pathname-version x))) + (mixf hash (sxhash-recurse (if (eq version :newest) + nil + version) + depthoid))))) + (layout + ;; LAYOUTs have an easily-accesible hash value: we + ;; might as well use it. It's not actually uniform + ;; over the space of hash values (it excludes 0 and + ;; some of the larger numbers) but it's better than + ;; simply returning the same value for all LAYOUT + ;; objects, as the next branch would do. + (layout-clos-hash x)) + ((or structure-object condition) + (logxor 422371266 + (sxhash ; through DEFTRANSFORM + (classoid-name + (layout-classoid (%instance-layout x)))))) + (t (sxhash-instance x)))) + (symbol (sxhash x)) ; through DEFTRANSFORM (array (typecase x (simple-string (sxhash x)) ; through DEFTRANSFORM -- 2.11.4.GIT