| commit | 44ebecaaed17b55a4429ac137036c9894b0dd730 | |
| author | Douglas Katzman <dougk@google.com> | |
| Fri, 20 Oct 2017 20:35:56 +0000 (20 16:35 -0400) | ||
| committer | Douglas Katzman <dougk@google.com> | |
| Fri, 20 Oct 2017 20:39:45 +0000 (20 16:39 -0400) | ||
| tree | 3a1399937f20a2af3fedf51a07acad27d1533b00 | treesnapshot (tar.gz zip) |
| parent | 4bc48a90062da0033041a705cd6174757c20cd2f | commitdiff |
Fixes for running with undefined-behavior sanitizer
- Terminate iteration of load_core_file() loop before remaining_len
transitions to a "negative" (large positive) value.
(It's an os_vm_size_t so this is flagged as causing wraparound on addition)
- Use memcpy() for all unaligned loads/stores.
C compilers optimize that into a single instruction where possible.
- Spell 1 as 1U whenever it might get shifted leftward by 31 bits.
- Don't left-shift a negative number ever.
- Terminate iteration of load_core_file() loop before remaining_len
transitions to a "negative" (large positive) value.
(It's an os_vm_size_t so this is flagged as causing wraparound on addition)
- Use memcpy() for all unaligned loads/stores.
C compilers optimize that into a single instruction where possible.
- Spell 1 as 1U whenever it might get shifted leftward by 31 bits.
- Don't left-shift a negative number ever.