From ad9a414147aa8699a84d930fb322b2a6b4f32e78 Mon Sep 17 00:00:00 2001 From: Martin Schwenke Date: Wed, 16 Feb 2022 08:44:40 +1100 Subject: [PATCH] vfs_not_implemented: do not mark structs with _PUBLIC_ Commit 5d295e41af4e9316aee1b4cf1c3087663b7c06a4 accidentally marked some structs with _PUBLIC_, which causes clang to complain: ../../source3/modules/vfs_not_implemented.c:594:1: error: attribute 'visibility' is ignored, place it after "struct" to apply attribute to type declaration [-Werror,-Wignored-attributes] _PUBLIC_ ^ ../../lib/replace/replace.h:917:33: note: expanded from macro '_PUBLIC_' ^ ../../source3/modules/vfs_not_implemented.c:642:1: error: attribute 'visibility' is ignored, place it after "struct" to apply attribute to type declaration [-Werror,-Wignored-attributes] _PUBLIC_ ^ ../../lib/replace/replace.h:917:33: note: expanded from macro '_PUBLIC_' ^ Signed-off-by: Martin Schwenke Reviewed-by: Volker Lendecke --- source3/modules/vfs_not_implemented.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/source3/modules/vfs_not_implemented.c b/source3/modules/vfs_not_implemented.c index 95c1757a7cc..fcc1ca1abbe 100644 --- a/source3/modules/vfs_not_implemented.c +++ b/source3/modules/vfs_not_implemented.c @@ -591,7 +591,6 @@ uint64_t vfs_not_implemented_fs_file_id(vfs_handle_struct *handle, return 0; } -_PUBLIC_ struct vfs_not_implemented_offload_read_state { bool dummy; }; @@ -639,7 +638,6 @@ NTSTATUS vfs_not_implemented_offload_read_recv(struct tevent_req *req, return NT_STATUS_OK; } -_PUBLIC_ struct vfs_not_implemented_offload_write_state { uint64_t unused; }; -- 2.11.4.GIT