From 2435ab1ad7092c004df72c2cb033eb94e5bf8274 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 17 Apr 2024 21:02:03 +0200 Subject: [PATCH] ldb_ildap: require ldb_get_opaque(ldb, "loadparm") to be valid Without a valid loadparm_context we can't connect. Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett --- lib/ldb-samba/ldb_ildap.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/ldb-samba/ldb_ildap.c b/lib/ldb-samba/ldb_ildap.c index 37ef185fbbf..0c051f143a7 100644 --- a/lib/ldb-samba/ldb_ildap.c +++ b/lib/ldb-samba/ldb_ildap.c @@ -917,6 +917,12 @@ static int ildb_connect(struct ldb_context *ldb, const char *url, struct cli_credentials *creds; struct loadparm_context *lp_ctx; + lp_ctx = talloc_get_type(ldb_get_opaque(ldb, "loadparm"), + struct loadparm_context); + if (lp_ctx == NULL) { + return ldb_operr(ldb); + } + module = ldb_module_new(ldb, ldb, "ldb_ildap backend", &ildb_ops); if (!module) return LDB_ERR_OPERATIONS_ERROR; @@ -929,9 +935,6 @@ static int ildb_connect(struct ldb_context *ldb, const char *url, ildb->event_ctx = ldb_get_event_context(ldb); - lp_ctx = talloc_get_type(ldb_get_opaque(ldb, "loadparm"), - struct loadparm_context); - ildb->ldap = ldap4_new_connection(ildb, lp_ctx, ildb->event_ctx); if (!ildb->ldap) { -- 2.11.4.GIT