pytest: sid_strings: adjust to match Windows 2016
commitedf9b282ba6e3fc089ab2d8a4db122b300b95fe4
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 2 May 2024 23:24:02 +0000 (3 11:24 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 7 May 2024 23:25:35 +0000 (7 23:25 +0000)
tree897924d6b0fe7a16c4edd4c1a6c58564c9239497
parent473502d170190b6bfe8da29708d347b16e0a2f7f
pytest: sid_strings: adjust to match Windows 2016

9 hex-digit subauths like '0xABCDef123' will not fit in 32 bits, so
should be rejected on parsing.

In other situations, such as defaultSecurityDescriptor, overflowing
SID subauths on Windows will saturate to 0xffffffff, resulting in a
valid but probably meaningless SID. It is possible that in previous
testing we saw that here, but it is more likely I got confused. In any
case, now I see them being rejected, and that is good.

The saturating defaultSecurityDescriptor case is tested in
SidStringBehavioursThatWindowsAllows.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10763

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/sid_strings.py
selftest/knownfail.d/sid-strings