| commit | f4db93b375109152919984d01c850b8cdcd0f7b5 | |
| author | Steffen Nurpmeso <steffen@sdaoden.eu> | |
| Thu, 15 Mar 2018 15:45:54 +0000 (15 16:45 +0100) | ||
| committer | Steffen Nurpmeso <steffen@sdaoden.eu> | |
| Thu, 15 Mar 2018 15:55:25 +0000 (15 16:55 +0100) | ||
| tree | 94ebd3ba01ac14048cde22a6b39eebc4d13bb056 | treesnapshot (tar.gz zip) |
| parent | 21a06a2ba62a5fa35741886d46d62c83b03c0704 | commitdiff |
n_folder_mbox_prepare_append(): FIX invalid MBOXes (broken by [90861930])..
RFC 4155 specifies that each record in an MBOX file must be
terminated with an completely empty line. Apparantly there is
still software out there which does not place this trailing
newline when appending messages to MBOX files, and since i have
added n_folder_mbox_prepare_append() in commit [90861930] last
year we do no longer handle this case due to a missing switch()
fallthrough.
Instead do it all differently and require a read of 1 for files of
1 byte, and 2 for files of 2 bytes or more. And thus handle those
boxes correctly again.
RFC 4155 specifies that each record in an MBOX file must be
terminated with an completely empty line. Apparantly there is
still software out there which does not place this trailing
newline when appending messages to MBOX files, and since i have
added n_folder_mbox_prepare_append() in commit [90861930] last
year we do no longer handle this case due to a missing switch()
fallthrough.
Instead do it all differently and require a read of 1 for files of
1 byte, and 2 for files of 2 bytes or more. And thus handle those
boxes correctly again.
| folder.c | diffblobblamehistory |