| commit | 8e7f0f4994b6cc77bf66bcc41b53bd05d62a8a39 | |
| author | Steffen (Daode) Nurpmeso <sdaoden@users.sf.net> | |
| Sat, 26 Dec 2015 13:45:51 +0000 (26 14:45 +0100) | ||
| committer | Steffen (Daode) Nurpmeso <sdaoden@users.sf.net> | |
| Sat, 26 Dec 2015 13:53:19 +0000 (26 14:53 +0100) | ||
| tree | 99e3630fd3b9342a4f112de231b3b639061aadc2 | treesnapshot (tar.gz zip) |
| parent | f0bbd72966507ce773af943d41d6646d17083545 | commitdiff |
Zopen(): FIX crash in error path (since ever!)..
Don't use Fclose() but fclose() on the temporary output file in
the error path since that file is not yet register_file()d at the
time those errors occur!
This error exists since ever, however it is only really, really
dramatical since we do support *file-hook-EXTENSION*. Right??
On the other hand i've used DBGOR() and don't panic but only alert
in the non-debug path, so that users of, e.g., ArchLinux mailx?(1)
only see "Alert: Invalid file pointer" and possibly accept it.
Our poor users!
Don't use Fclose() but fclose() on the temporary output file in
the error path since that file is not yet register_file()d at the
time those errors occur!
This error exists since ever, however it is only really, really
dramatical since we do support *file-hook-EXTENSION*. Right??
On the other hand i've used DBGOR() and don't panic but only alert
in the non-debug path, so that users of, e.g., ArchLinux mailx?(1)
only see "Alert: Invalid file pointer" and possibly accept it.
Our poor users!
| popen.c | diffblobblamehistory |