| commit | 35561c491584a22b82dec5f37b84f792aa8a278b | |
| author | Dmytro Shteflyuk <kpumuk@kpumuk.info> | |
| Tue, 25 Jul 2017 20:02:42 +0000 (25 16:02 -0400) | ||
| committer | Eric Wong <e@80x24.org> | |
| Tue, 25 Jul 2017 20:53:23 +0000 (25 20:53 +0000) | ||
| tree | 278267ccd20f847cf2090bda2100e15eed95e7fa | treesnapshot (tar.gz zip) |
| parent | 3a81c82c5c03a33ebe6b55a778fc43280a44d119 | commitdiff |
Properly override respond_to? in Raindrops::Middleware::Proxy
Correct method definition according to Ruby documentation (https://ruby-doc.org/core-2.4.1/Object.html#method-i-respond_to-3F) is:
respond_to?(string, include_all=false) → true or false
Rack started using second argument starting from version 2:
https://github.com/rack/rack/blob/master/lib/rack/body_proxy.rb#L14
If raindrops is used in Rack 2+ applications, an exception is raised:
ArgumentError: wrong number of arguments (2 for 1)
<ROOT>/gems/raindrops-0.18.0/lib/raindrops/middleware/proxy.rb:30:in `respond_to?'
<ROOT>/gems/rack-2.0.3/lib/rack/body_proxy.rb:14:in `respond_to?'
Correct method definition according to Ruby documentation (https://ruby-doc.org/core-2.4.1/Object.html#method-i-respond_to-3F) is:
respond_to?(string, include_all=false) → true or false
Rack started using second argument starting from version 2:
https://github.com/rack/rack/blob/master/lib/rack/body_proxy.rb#L14
If raindrops is used in Rack 2+ applications, an exception is raised:
ArgumentError: wrong number of arguments (2 for 1)
<ROOT>/gems/raindrops-0.18.0/lib/raindrops/middleware/proxy.rb:30:in `respond_to?'
<ROOT>/gems/rack-2.0.3/lib/rack/body_proxy.rb:14:in `respond_to?'
| lib/raindrops/middleware/proxy.rb | diffblobblamehistory |