| commit | 0ba33d83108f21abbd98cde1accdbba5bce625d2 | |
| author | João Abecasis <joao@abecasis.name> | |
| Fri, 17 Jul 2009 13:31:41 +0000 (17 15:31 +0200) | ||
| committer | João Abecasis <joao@abecasis.name> | |
| Wed, 22 Jul 2009 12:36:16 +0000 (22 14:36 +0200) | ||
| tree | 3cd58e3f9a3eb176d89d9757ac50fba208319826 | treesnapshot (tar.gz zip) |
| parent | f2dce82831706a38cd97225edb2edc0ed2a1520e | commitdiff |
QDirIterator: no point in delaying the inevitable
The only reason I see for not calling advance() directly in the
constructor is to delay potentially unnecessary work.
However, since copy constructors have been explicitly disabled, once
QDirIterator is instantiated one has signed up for all the pain that
comes with it.
That's also a couple less conditionals in each iteration of normal use
cases.
Reviewed-by: Marius Storm-Olsen
The only reason I see for not calling advance() directly in the
constructor is to delay potentially unnecessary work.
However, since copy constructors have been explicitly disabled, once
QDirIterator is instantiated one has signed up for all the pain that
comes with it.
That's also a couple less conditionals in each iteration of normal use
cases.
Reviewed-by: Marius Storm-Olsen
| src/corelib/io/qdiriterator.cpp | diffblobblamehistory |