| commit | d21357df9a2a6b7e6bb2f579d04877f3bd65c557 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Tue, 1 Jun 2010 18:32:31 +0000 (1 20:32 +0200) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Fri, 4 Jun 2010 09:43:39 +0000 (4 11:43 +0200) | ||
| tree | 7397e5342d9c2e51eddfe63b38a13b63d966fb2d | treesnapshot (tar.gz zip) |
| parent | cc98467327e13adca8f65b5a841c08930ee68220 | commitdiff |
qdev: Don't leak string property value on hot unplug
parse_string() qemu_strdup()s the property value. It is never freed.
It needs to be freed along with the device. Otherwise, the value of
scsi-disk property "ver" gets leaked when hot-unplugging the disk, for
instance.
Call new PropertyInfo method free() from qdev_free(). Implement it
for qdev_prop_string.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
parse_string() qemu_strdup()s the property value. It is never freed.
It needs to be freed along with the device. Otherwise, the value of
scsi-disk property "ver" gets leaked when hot-unplugging the disk, for
instance.
Call new PropertyInfo method free() from qdev_free(). Implement it
for qdev_prop_string.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| hw/qdev-properties.c | diffblobblamehistory | |
| hw/qdev.c | diffblobblamehistory | |
| hw/qdev.h | diffblobblamehistory |