| commit | f4f872b532a53da7bc734cdb7cb166ec22d617d1 | |
| author | Gollu Appalanaidu <anaidu.gollu@samsung.com> | |
| Mon, 22 Feb 2021 18:36:09 +0000 (22 19:36 +0100) | ||
| committer | Klaus Jensen <k.jensen@samsung.com> | |
| Tue, 9 Mar 2021 10:00:57 +0000 (9 11:00 +0100) | ||
| tree | 37186cbffc156820eca89f6a94012d8f8d6736ea | treesnapshot (tar.gz zip) |
| parent | 49f0eba8b2bdc0c9aeaac620b978da7cb0fa947f | commitdiff |
hw/block/nvme: fix potential compilation error
assert may be compiled to a noop and we could end up returning an
uninitialized status.
Fix this by always returning Internal Device Error as a fallback.
Note that, as pointed out by Philippe, per commit 262a69f4282 ("osdep.h:
Prohibit disabling assert() in supported builds") this shouldn't be
possible. But clean it up so we don't worry about it again.
Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
[k.jensen: split commit]
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
assert may be compiled to a noop and we could end up returning an
uninitialized status.
Fix this by always returning Internal Device Error as a fallback.
Note that, as pointed out by Philippe, per commit 262a69f4282 ("osdep.h:
Prohibit disabling assert() in supported builds") this shouldn't be
possible. But clean it up so we don't worry about it again.
Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
[k.jensen: split commit]
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
| hw/block/nvme.c | diffblobblamehistory |