| commit | eb69953ecb1cbe7b4c4093a97a4dab3daa315d4e | |
| author | Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> | |
| Tue, 27 Mar 2018 04:38:00 +0000 (27 00:38 -0400) | ||
| committer | John Snow <jsnow@redhat.com> | |
| Tue, 27 Mar 2018 04:38:00 +0000 (27 00:38 -0400) | ||
| tree | a629affc2b47916bae0220135118ee53d852d114 | treesnapshot (tar.gz zip) |
| parent | caeadbc8ba4227f56957203fff0e4058eeb5f1b0 | commitdiff |
macio: fix NULL pointer dereference when issuing IDE trim
Commit ef0e64a983 "ide: pass IDEState to trim AIO callback" changed the
IDE trim callback from using a BlockBackend to an IDEState but forgot to update
the dma_blk_io() call in hw/ide/macio.c accordingly.
Without this fix qemu-system-ppc segfaults when issuing an IDE trim command on
any of the PPC Mac machines (easily triggered by running the Debian installer).
Reported-by: Howard Spoelstra <hsp.cat7@gmail.com>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Message-id: 20180223184700.28854-1-mark.cave-ayland@ilande.co.uk
Signed-off-by: John Snow <jsnow@redhat.com>
Commit ef0e64a983 "ide: pass IDEState to trim AIO callback" changed the
IDE trim callback from using a BlockBackend to an IDEState but forgot to update
the dma_blk_io() call in hw/ide/macio.c accordingly.
Without this fix qemu-system-ppc segfaults when issuing an IDE trim command on
any of the PPC Mac machines (easily triggered by running the Debian installer).
Reported-by: Howard Spoelstra <hsp.cat7@gmail.com>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Message-id: 20180223184700.28854-1-mark.cave-ayland@ilande.co.uk
Signed-off-by: John Snow <jsnow@redhat.com>
| hw/ide/macio.c | diffblobblamehistory |