coroutine-sleep: allow qemu_co_sleep_wake that wakes nothing
commiteaee0720851f22b273099eaf4c02722d9f24340a
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 17 May 2021 10:05:45 +0000 (17 12:05 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 21 May 2021 17:22:33 +0000 (21 18:22 +0100)
tree4ffbc1e74cc8d43acf9a5c836f6ae51e56572bfd
parentfb74a286feaa4ec2cdcda61ba570244464581ca7
coroutine-sleep: allow qemu_co_sleep_wake that wakes nothing

All callers of qemu_co_sleep_wake are checking whether they are passing
a NULL argument inside the pointer-to-pointer: do the check in
qemu_co_sleep_wake itself.

As a side effect, qemu_co_sleep_wake can be called more than once and
it will only wake the coroutine once; after the first time, the argument
will be set to NULL via *sleep_state->user_state_pointer.  However, this
would not be safe unless co_sleep_cb keeps using the QemuCoSleepState*
directly, so make it go through the pointer-to-pointer instead.

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20210517100548.28806-4-pbonzini@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/block-copy.c
block/nbd.c
util/qemu-coroutine-sleep.c