error: Use error_reportf_err() where it makes obvious sense
commitc29b77f955ff2f7b57c1e71e9dc26243eefd0b28
authorMarkus Armbruster <armbru@redhat.com>
Fri, 18 Dec 2015 15:35:14 +0000 (18 16:35 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 13 Jan 2016 14:16:17 +0000 (13 15:16 +0100)
treec76f9b9338d5a1cefef00917260242c4d04285c5
parent8aa802a6b768e811e492c7404a58c52ecfb382ed
error: Use error_reportf_err() where it makes obvious sense

Done with this Coccinelle semantic patch

    @@
    expression FMT, E, S;
    expression list ARGS;
    @@
    -    error_report(FMT, ARGS, error_get_pretty(E));
    +    error_reportf_err(E, FMT/*@@@*/, ARGS);
    (
    -    error_free(E);
    |
 exit(S);
    |
 abort();
    )

followed by a replace of '%s"/*@@@*/' by '"' and some line rewrapping,
because I can't figure out how to make Coccinelle transform strings.

We now use the error whole instead of just its message obtained with
error_get_pretty().  This avoids suppressing its hint (see commit
50b7b00), but I can't see how the errors touched in this commit could
come with hints.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1450452927-8346-12-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
17 files changed:
arch_init.c
block/sheepdog.c
blockdev.c
hw/arm/cubieboard.c
hw/arm/digic_boards.c
hw/core/qdev-properties.c
hw/core/qdev.c
hw/i386/pc.c
hw/ppc/e500.c
hw/usb/bus.c
qemu-img.c
qemu-nbd.c
replay/replay.c
tests/test-aio.c
tests/test-thread-pool.c
ui/vnc.c
vl.c