| commit | 87ac25fd1fed05a30a93d27dbeb2a4c4b83ec95f | |
| author | John Snow <jsnow@redhat.com> | |
| Thu, 28 Jul 2016 21:34:19 +0000 (28 17:34 -0400) | ||
| committer | John Snow <jsnow@redhat.com> | |
| Thu, 28 Jul 2016 21:34:19 +0000 (28 17:34 -0400) | ||
| tree | cace533d438452dc14a833bb32cd827875a2d193 | treesnapshot (tar.gz zip) |
| parent | 21a21b853a1bb606358af61e738abfb9aecbd720 | commitdiff |
ide: fix halted IO segfault at reset
If one attempts to perform a system_reset after a failed IO request
that causes the VM to enter a paused state, QEMU will segfault trying
to free up the pending IO requests.
These requests have already been completed and freed, though, so all
we need to do is NULL them before we enter the paused state.
Existing AHCI tests verify that halted requests are still resumed
successfully after a STOP event.
Analyzed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 1469635201-11918-2-git-send-email-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
If one attempts to perform a system_reset after a failed IO request
that causes the VM to enter a paused state, QEMU will segfault trying
to free up the pending IO requests.
These requests have already been completed and freed, though, so all
we need to do is NULL them before we enter the paused state.
Existing AHCI tests verify that halted requests are still resumed
successfully after a STOP event.
Analyzed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 1469635201-11918-2-git-send-email-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
| hw/ide/core.c | diffblobblamehistory |