memory: unregister AddressSpace MemoryListener within BQL
commit6e48e8f9e0f5b6b15c41f6f8a68c9bf330147d45
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 10 Feb 2015 17:25:44 +0000 (10 10:25 -0700)
committerAlex Williamson <alex.williamson@redhat.com>
Tue, 10 Feb 2015 17:25:44 +0000 (10 10:25 -0700)
tree581914a4756e758a24b878dcb953d6e758ea19df
parenta2f2d288b5a06e6c680c387c9980d91363f59c61
memory: unregister AddressSpace MemoryListener within BQL

address_space_destroy_dispatch is called from an RCU callback and hence
outside the iothread mutex (BQL).  However, after address_space_destroy
no new accesses can hit the destroyed AddressSpace so it is not necessary
to observe changes to the memory map.  Move the memory_listener_unregister
call earlier, to make it thread-safe again.

Reported-by: Alex Williamson <alex.williamson@redhat.com>
Fixes: 374f2981d1f10bc4307f250f24b2a7ddb9b14be0
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
exec.c
include/exec/memory-internal.h
memory.c