hw/display/bcm2835_fb: Fix framebuffer allocation address
commit5865d99fe88d8c8fa437c18c6b63fb2a8165634f
authorAlan Jian <alanjian85@gmail.com>
Mon, 25 Jul 2022 14:58:39 +0000 (25 22:58 +0800)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 26 Jul 2022 13:09:44 +0000 (26 14:09 +0100)
tree49894f0f78a29ada64fca2b629a7fa652a48feef
parentc5cfdabaf5ba0963292d3f0e318170ae9fab3fcc
hw/display/bcm2835_fb: Fix framebuffer allocation address

This patch fixes the dedicated framebuffer mailbox interface by
removing an unneeded offset.  This means that we pick the framebuffer
address in the same way that we do if the guest code uses the buffer
allocate mechanism of the bcm2835_property interface (case
0x00040001: /* Allocate buffer */ in bcm2835_property.c).

The documentation of this mailbox interface doesn't say anything
about using parts of the request buffer address to affect the
chosen framebuffer address:
https://github.com/raspberrypi/firmware/wiki/Mailbox-framebuffer-interface

Some baremetal applications like the Screen01/Screen02 examples from
Baking Pi tutorial[1] didn't work before this patch.

[1] https://www.cl.cam.ac.uk/projects/raspberrypi/tutorials/os/screen01.html

Signed-off-by: Alan Jian <alanjian85@outlook.com>
Message-id: 20220725145838.8412-1-alanjian85@outlook.com
[PMM: tweaked commit message]
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/display/bcm2835_fb.c