| commit | 27d9ffd4b3718707c302fc0aad4746b958443c3a | |
| author | David Gibson <david@gibson.dropbear.id.au> | |
| Mon, 14 Nov 2016 09:12:57 +0000 (14 10:12 +0100) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Mon, 14 Nov 2016 23:08:43 +0000 (15 10:08 +1100) | ||
| tree | 4792b34bd5b15c5c143741275e24cf21ef294688 | treesnapshot (tar.gz zip) |
| parent | f81e551229070f01bf747eda3f05960182db9d2a | commitdiff |
ppc/pnv: Fix fatal bug on 32-bit hosts
If the pnv machine type is compiled on a 32-bit host, the unsigned long
(host) type is 32-bit. This means that the hweight_long() used to
calculate the number of allowed cores only considers the low 32 bits of
the cores_mask variable, and can thus return 0 in some circumstances.
This corrects the bug.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Suggested-by: Richard Henderson <rth@twiddle.net>
[clg: replaced hweight_long() by ctpop64() ]
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
If the pnv machine type is compiled on a 32-bit host, the unsigned long
(host) type is 32-bit. This means that the hweight_long() used to
calculate the number of allowed cores only considers the low 32 bits of
the cores_mask variable, and can thus return 0 in some circumstances.
This corrects the bug.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Suggested-by: Richard Henderson <rth@twiddle.net>
[clg: replaced hweight_long() by ctpop64() ]
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| hw/ppc/pnv.c | diffblobblamehistory |