qemu: x86: ignore ioapic polarity
commit220c8ed536491315b4040d820328b8dfd60d67a7
authorGabriel L. Somlo <gsomlo@gmail.com>
Fri, 28 Feb 2014 18:57:19 +0000 (28 13:57 -0500)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 9 Mar 2014 19:09:38 +0000 (9 21:09 +0200)
tree6c1002136e9e68984004b535845016bb0032d9e6
parentf1b7e0e498c03e5b4519eeea73b49aafe9d88618
qemu: x86: ignore ioapic polarity

Both QEMU and KVM have already accumulated a significant number of
optimizations based on the hard-coded assumption that ioapic polarity
will always use the ActiveHigh convention, where the logical and
physical states of level-triggered irq lines always match (i.e.,
active(asserted) == high == 1, inactive == low == 0). QEMU guests
are expected to follow directions given via ACPI and configure the
ioapic with polarity 0 (ActiveHigh). However, even when misbehaving
guests (e.g. OS X <= 10.9) set the ioapic polarity to 1 (ActiveLow),
QEMU will still use the ActiveHigh signaling convention when
interfacing with the emulated ioapic.

This patch modifies the emulated ioapic to completely ignore polarity
as set by the guest OS, enabling misbehaving guests to work alongside
those which comply with the ActiveHigh polarity specified by QEMU's
ACPI tables.

Signed-off-by: Gabriel L. Somlo <somlo@cmu.edu>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/intc/ioapic.c