s390x: Replace unchecked qdev_init() by qdev_init_nofail()
commitae4a2bd759d647dd6146d45e4a59a01cf34d6a4d
authorMarkus Armbruster <armbru@redhat.com>
Thu, 5 Feb 2015 09:34:49 +0000 (5 10:34 +0100)
committerCornelia Huck <cornelia.huck@de.ibm.com>
Mon, 16 Mar 2015 09:15:44 +0000 (16 10:15 +0100)
tree4acd746276386df2b6bcd8cada6beb3f96429d1f
parent7ccfb495c64e1eef5886dcc4d48523ed6d1d22a4
s390x: Replace unchecked qdev_init() by qdev_init_nofail()

s390_flic_init() is a helper to create and realize either
"s390-flic-kvm" or "s390-flic-qemu".  When qdev_init() fails, it
complains to stderr and succeeds.

Except it can't actually fail, because the "s390-flic-qemu" is a dummy
without a realize method, and "s390-flic-kvm"'s realize can't fail,
even when the kernel device is really unavailable.  Odd.

Replace qdev_init() by qdev_init_nofail() to make "can't fail" locally
obvious, and get rid of the unreachable error reporting.

Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-Id: <1423128889-18260-4-git-send-email-armbru@redhat.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
hw/intc/s390_flic.c