From 3c83eb4f17ffa981cb60b965087769b808062a3a Mon Sep 17 00:00:00 2001 From: Blue Swirl Date: Sun, 18 Apr 2010 08:45:03 +0000 Subject: [PATCH] Fix harmless if statements with empty body, spotted by clang These clang errors are harmless but worth fixing: CC libhw64/fdc.o /src/qemu/hw/fdc.c:998:74: error: if statement has empty body [-Wempty-body] FLOPPY_DPRINTF("Floppy digital input register: 0x%02x\n", retval); CC libhw64/cuda.o /src/qemu/hw/cuda.c:320:66: error: if statement has empty body [-Wempty-body] CUDA_DPRINTF("read: reg=0x%x val=%02x\n", (int)addr, val); Signed-off-by: Blue Swirl --- hw/cuda.c | 4 +++- hw/fdc.c | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/cuda.c b/hw/cuda.c index 83ae68ad59..50950d9100 100644 --- a/hw/cuda.c +++ b/hw/cuda.c @@ -316,8 +316,10 @@ static uint32_t cuda_readb(void *opaque, target_phys_addr_t addr) val = s->anh; break; } - if (addr != 13 || val != 0) + if (addr != 13 || val != 0) { CUDA_DPRINTF("read: reg=0x%x val=%02x\n", (int)addr, val); + } + return val; } diff --git a/hw/fdc.c b/hw/fdc.c index 93a7f1d1c9..c4ca9e9021 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -994,8 +994,9 @@ static uint32_t fdctrl_read_dir(FDCtrl *fdctrl) #endif ) retval |= FD_DIR_DSKCHG; - if (retval != 0) + if (retval != 0) { FLOPPY_DPRINTF("Floppy digital input register: 0x%02x\n", retval); + } return retval; } -- 2.11.4.GIT