From 2ab3cb8c0ae79c96f38f6bfd35620cc18ddba19f Mon Sep 17 00:00:00 2001 From: Jes Sorensen Date: Thu, 28 Apr 2011 13:58:30 +0200 Subject: [PATCH] qemu-progress.c: printf isn't signal safe Change the signal handling to indicate a signal is pending, rather then printing directly from the signal handler. In addition make the signal prints go to stderr, rather than stdout. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- qemu-progress.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qemu-progress.c b/qemu-progress.c index e1feb89614..a4894c0dfc 100644 --- a/qemu-progress.c +++ b/qemu-progress.c @@ -37,6 +37,7 @@ struct progress_state { }; static struct progress_state state; +static volatile sig_atomic_t print_pending; /* * Simple progress print function. @@ -63,12 +64,16 @@ static void progress_simple_init(void) #ifdef CONFIG_POSIX static void sigusr_print(int signal) { - printf(" (%3.2f/100%%)\n", state.current); + print_pending = 1; } #endif static void progress_dummy_print(void) { + if (print_pending) { + fprintf(stderr, " (%3.2f/100%%)\n", state.current); + print_pending = 0; + } } static void progress_dummy_end(void) -- 2.11.4.GIT