| commit | 33bbd1de5ec9b8802d63e811908f2351ba83884c | |
| author | Avi Kivity <avi@redhat.com> | |
| Tue, 16 Nov 2010 14:33:17 +0000 (16 16:33 +0200) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Sun, 21 Nov 2010 15:16:57 +0000 (21 09:16 -0600) | ||
| tree | 83a5c677c69dd0da3ee94732b5ee4920743aaf7d | treesnapshot (tar.gz zip) |
| parent | e71e00ed258202052570ae631536f4d7b65792fa | commitdiff |
optionrom: fix bugs in signrom.sh
signrom.sh has multiple bugs:
- the last byte is considered when calculating the existing checksum, but not
when computing the correction
- apprently the 'expr' expression overflows and produces incorrect results with
larger roms
- if the checksum happened to be zero, we calculated the correction byte to be
256
Instead of rewriting this in half a line of python, this patch fixes the bugs.
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
signrom.sh has multiple bugs:
- the last byte is considered when calculating the existing checksum, but not
when computing the correction
- apprently the 'expr' expression overflows and produces incorrect results with
larger roms
- if the checksum happened to be zero, we calculated the correction byte to be
256
Instead of rewriting this in half a line of python, this patch fixes the bugs.
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| pc-bios/optionrom/signrom.sh | diffblobblamehistory |