| commit | 9ee05825d9eaf7fe3aaed5ed04b83612ede704a0 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Fri, 25 Sep 2009 01:53:50 +0000 (25 03:53 +0200) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Mon, 5 Oct 2009 14:32:53 +0000 (5 09:32 -0500) | ||
| tree | 26308c0eb957d23a488e5c5ceeb5e23647a6ae1d | treesnapshot (tar.gz zip) |
| parent | 49bd1458da8909434eb83c5cda472c63ff6a529c | commitdiff |
Make it obvious that pci_nic_init() can't fail
Before this patch, pci_nic_init() returns NULL when it can't find the
model in pci_nic_models[]. Except this can't happen, because
qemu_check_nic_model_list() just searched for model in
pci_nic_models[], and terminated the program on failure.
Repeating the search here is pointless. Instead, change
qemu_check_nic_model_list() to return the model's array index.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Before this patch, pci_nic_init() returns NULL when it can't find the
model in pci_nic_models[]. Except this can't happen, because
qemu_check_nic_model_list() just searched for model in
pci_nic_models[], and terminated the program on failure.
Repeating the search here is pointless. Instead, change
qemu_check_nic_model_list() to return the model's array index.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| hw/pci.c | diffblobblamehistory | |
| net.c | diffblobblamehistory | |
| net.h | diffblobblamehistory |