From ff9d3e9cd9f7c41d8b822c0d12b0176d8e7e530d Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Mon, 11 Jul 2016 19:09:12 +0100 Subject: [PATCH] target-arm: Fix unreachable code in gicv3_class_name() Coverity complains that the exit() in gicv3_class_name() can be unreachable, because if TARGET_AARCH64 is defined then all code paths return before reaching it. Move the exit() up to the error_report() that it belongs with. Signed-off-by: Peter Maydell Reviewed-by: Shannon Zhao Message-id: 1468260552-8400-1-git-send-email-peter.maydell@linaro.org --- target-arm/machine.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-arm/machine.c b/target-arm/machine.c index 2dbeb826cd..7a6ca31a8e 100644 --- a/target-arm/machine.c +++ b/target-arm/machine.c @@ -340,10 +340,9 @@ const char *gicv3_class_name(void) #else error_report("KVM GICv3 acceleration is not supported on this " "platform"); + exit(1); #endif } else { return "arm-gicv3"; } - - exit(1); } -- 2.11.4.GIT