From 1813d33015f0a6780609739999f3962f2dc56921 Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Thu, 15 Sep 2016 17:44:16 +0200 Subject: [PATCH] hmp: Remove dead code in hmp_qemu_io() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit blk can never be NULL, drop the check. This fixes a Coverity warning. Signed-off-by: Kevin Wolf Reviewed-by: Marc-André Lureau --- hmp.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/hmp.c b/hmp.c index ad33b442d2..0a16aefc2a 100644 --- a/hmp.c +++ b/hmp.c @@ -1924,6 +1924,7 @@ void hmp_qemu_io(Monitor *mon, const QDict *qdict) { BlockBackend *blk; BlockBackend *local_blk = NULL; + AioContext *aio_context; const char* device = qdict_get_str(qdict, "device"); const char* command = qdict_get_str(qdict, "command"); Error *err = NULL; @@ -1939,17 +1940,12 @@ void hmp_qemu_io(Monitor *mon, const QDict *qdict) } } - if (blk) { - AioContext *aio_context = blk_get_aio_context(blk); - aio_context_acquire(aio_context); + aio_context = blk_get_aio_context(blk); + aio_context_acquire(aio_context); - qemuio_command(blk, command); + qemuio_command(blk, command); - aio_context_release(aio_context); - } else { - error_set(&err, ERROR_CLASS_DEVICE_NOT_FOUND, - "Device '%s' not found", device); - } + aio_context_release(aio_context); fail: blk_unref(local_blk); -- 2.11.4.GIT