| commit | fe2a9303c9e511462f662a415c2e9d2defe9b7ca | |
| author | Eric Blake <eblake@redhat.com> | |
| Mon, 4 May 2015 15:05:02 +0000 (4 09:05 -0600) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Tue, 5 May 2015 16:39:00 +0000 (5 18:39 +0200) | ||
| tree | 9fd7bef56fe096410f20aae809a59e3fd3b66f43 | treesnapshot (tar.gz zip) |
| parent | cb17f79eef0d161e81ac457e4c1f124405be2a18 | commitdiff |
qapi: Require ASCII in schema
Python 2 and Python 3 have a wild history of whether strings
default to ascii or unicode, where Python 3 requires checking
isinstance(foo, basestr) to cover all strings, but where that
code is not portable to Python 2. It's simpler to just state
that we don't care about Unicode strings, and to just always
use the simpler isinstance(foo, str) everywhere.
I'm no python expert, so I'm basing it on this conversation:
https://lists.gnu.org/archive/html/qemu-devel/2014-09/msg05278.html
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Python 2 and Python 3 have a wild history of whether strings
default to ascii or unicode, where Python 3 requires checking
isinstance(foo, basestr) to cover all strings, but where that
code is not portable to Python 2. It's simpler to just state
that we don't care about Unicode strings, and to just always
use the simpler isinstance(foo, str) everywhere.
I'm no python expert, so I'm basing it on this conversation:
https://lists.gnu.org/archive/html/qemu-devel/2014-09/msg05278.html
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
| scripts/qapi.py | diffblobblamehistory |