| commit | f8154fd22bf80b1555bac46119747e899c09d0c9 | |
| author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | |
| Fri, 15 Feb 2019 16:16:45 +0000 (15 17:16 +0100) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Mon, 25 Feb 2019 22:21:24 +0000 (26 09:21 +1100) | ||
| tree | 0a0a86b075f140dd74b90857942f31221e647ccf | treesnapshot (tar.gz zip) |
| parent | a790e82b13854f443850cbf11b25cdb98f6885c5 | commitdiff |
target/ppc: Detect erroneous condition in interrupt delivery
It's very easy for the CPU specific has_work() implementation
and the logic in ppc_hw_interrupt() to be subtly out of sync.
This can occasionally allow a CPU to wakeup from a PM state
and resume executing past the PM instruction when it should
resume at the 0x100 vector.
This detects if it happens and aborts, making it a lot easier
to catch such bugs when testing rather than chasing obscure
guest misbehaviour.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20190215161648.9600-8-clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
It's very easy for the CPU specific has_work() implementation
and the logic in ppc_hw_interrupt() to be subtly out of sync.
This can occasionally allow a CPU to wakeup from a PM state
and resume executing past the PM instruction when it should
resume at the 0x100 vector.
This detects if it happens and aborts, making it a lot easier
to catch such bugs when testing rather than chasing obscure
guest misbehaviour.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20190215161648.9600-8-clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| target/ppc/excp_helper.c | diffblobblamehistory |