| commit | f0b1df5c4502b5ec89f83417924935ab201511d0 | |
| author | Akihiko Odaki <akihiko.odaki@daynix.com> | |
| Tue, 23 May 2023 02:42:57 +0000 (23 11:42 +0900) | ||
| committer | Jason Wang <jasowang@redhat.com> | |
| Tue, 23 May 2023 07:20:15 +0000 (23 15:20 +0800) | ||
| tree | eba013e6bf39778c538e8119fb6014e806897646 | treesnapshot (tar.gz zip) |
| parent | e209716749cda1581cfc8e582591c0216c30ab0d | commitdiff |
igb: Clear IMS bits when committing ICR access
The datasheet says contradicting statements regarding ICR accesses so it
is not reliable to determine the behavior of ICR accesses. However,
e1000e does clear IMS bits when reading ICR accesses and Linux also
expects ICR accesses will clear IMS bits according to:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/igb/igb_main.c?h=v6.2#n8048
Fixes: 3a977deebe ("Intrdocue igb device emulation")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
Signed-off-by: Jason Wang <jasowang@redhat.com>
The datasheet says contradicting statements regarding ICR accesses so it
is not reliable to determine the behavior of ICR accesses. However,
e1000e does clear IMS bits when reading ICR accesses and Linux also
expects ICR accesses will clear IMS bits according to:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/igb/igb_main.c?h=v6.2#n8048
Fixes: 3a977deebe ("Intrdocue igb device emulation")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
Signed-off-by: Jason Wang <jasowang@redhat.com>
| hw/net/igb_core.c | diffblobblamehistory |