tap-win32: skip unexpected nodes during registry enumeration
commitee0428e3acd237e4d555cc54134cea473cab5ee7
authorAndrew Baumann <Andrew.Baumann@microsoft.com>
Wed, 18 Nov 2015 19:45:08 +0000 (18 11:45 -0800)
committerJason Wang <jasowang@redhat.com>
Fri, 27 Nov 2015 02:39:55 +0000 (27 10:39 +0800)
tree32f3fbdba52121f3e8814a30f373a5fc4c43de6d
parent00837731d254908a841d69298a4f9f077babaf24
tap-win32: skip unexpected nodes during registry enumeration

In order to find a named tap device, get_device_guid() enumerates children of
HKLM\SYSTEM\CCS\Control\Network\{4D36E972-E325-11CE-BFC1-08002BE10318}
(aka NETWORK_CONNECTIONS_KEY). For each child, it then looks for a
"Connection" subkey, but if this key doesn't exist, it aborts the
entire search. This was observed to fail on at least one Windows 10
machine, where there is an additional child of NETWORK_CONNECTIONS_KEY
(named "Descriptions"). Since registry enumeration doesn't guarantee
any particular sort order, we should continue to search for matching
children rather than aborting the search.

Signed-off-by: Andrew Baumann <Andrew.Baumann@microsoft.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Jason Wang <jasowang@redhat.com>
net/tap-win32.c