migration (postcopy): move bdrv_invalidate_cache_all of of coroutine context
commitea6a55bcc0d144ac5086cebf7f84afa7071afe90
authorDenis V. Lunev <den@openvz.org>
Wed, 24 Feb 2016 08:53:39 +0000 (24 11:53 +0300)
committerAmit Shah <amit.shah@redhat.com>
Fri, 26 Feb 2016 15:10:08 +0000 (26 20:40 +0530)
tree321162f47f00aa2900e104ce625f4307f593e001
parent0aa6aefc9c93db1f64e3ba406ee5234da75b545b
migration (postcopy): move bdrv_invalidate_cache_all of of coroutine context

There is a possibility to hit an assert in qcow2_get_specific_info that
s->qcow_version is undefined. This happens when VM in starting from
suspended state, i.e. it processes incoming migration, and in the same
time 'info block' is called.

The problem is that qcow2_invalidate_cache() closes the image and
memset()s BDRVQcowState in the middle.

The patch moves processing of bdrv_invalidate_cache_all out of
coroutine context for postcopy migration to avoid that. This function
is called with the following stack:
  process_incoming_migration_co
  qemu_loadvm_state
  qemu_loadvm_state_main
  loadvm_process_command
  loadvm_postcopy_handle_run

Signed-off-by: Denis V. Lunev <den@openvz.org>
Tested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Juan Quintela <quintela@redhat.com>
CC: Amit Shah <amit.shah@redhat.com>
Message-Id: <1456304019-10507-3-git-send-email-den@openvz.org>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
migration/savevm.c