multifd: Unconditionally unregister yank function
commite9ab82b858c14aa76dac5235a99d1723ec069407
authorLukas Straub <lukasstraub2@web.de>
Thu, 9 Sep 2021 07:19:45 +0000 (9 09:19 +0200)
committerJuan Quintela <quintela@redhat.com>
Tue, 19 Oct 2021 06:39:04 +0000 (19 08:39 +0200)
tree0c572d9e4a79c05379c31c4b7377f4da6969f194
parent20171ea8950c619f00dc5cfa6136fd489998ffc5
multifd: Unconditionally unregister yank function

To: qemu-devel <qemu-devel@nongnu.org>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela
 <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras Soares
 Passos <lsoaresp@redhat.com>
Date: Wed, 4 Aug 2021 21:26:32 +0200 (5 weeks, 11 hours, 52 minutes ago)

[[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 2021-08-04T21:26:32+0200 using RSA]]
Unconditionally unregister yank function in multifd_load_cleanup().
If it is not unregistered here, it will leak and cause a crash
in yank_unregister_instance(). Now if the ioc is still in use
afterwards, it will only lead to qemu not being able to recover
from a hang related to that ioc.

After checking the code, i am pretty sure that ref is always 1
when arriving here. So all this currently does is remove the
unneeded check.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/multifd.c