| commit | e73255be96bf435fe6bf9a5c196dcd7c76adb0da | |
| author | Stefan Hajnoczi <stefanha@redhat.com> | |
| Wed, 23 Oct 2019 10:04:13 +0000 (23 11:04 +0100) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Fri, 25 Oct 2019 11:46:22 +0000 (25 07:46 -0400) | ||
| tree | 964539b964e4214eca8f4dc3d4b8dca90043569e | treesnapshot (tar.gz zip) |
| parent | a9340358f4d5d0e8e0c7a3a23cb4e5b68334974c | commitdiff |
virtio-scsi-test: add missing feature negotiation
VIRTIO Device Initialization requires feature negotiation. Currently
virtio-scsi-test.c is non-compliant.
libqos tests acknowledge all feature bits advertised by the device,
except VIRTIO_F_BAD_FEATURE (which devices use to detect broken
drivers!) and VIRTIO_RING_F_EVENT_IDX (which is not implemented in
libqos and accepting it would break notifications).
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20191023100425.12168-5-stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Thomas Huth" <thuth@redhat.com>
VIRTIO Device Initialization requires feature negotiation. Currently
virtio-scsi-test.c is non-compliant.
libqos tests acknowledge all feature bits advertised by the device,
except VIRTIO_F_BAD_FEATURE (which devices use to detect broken
drivers!) and VIRTIO_RING_F_EVENT_IDX (which is not implemented in
libqos and accepting it would break notifications).
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20191023100425.12168-5-stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Thomas Huth" <thuth@redhat.com>
| tests/virtio-scsi-test.c | diffblobblamehistory |