| commit | de258eb07db6cf893ef1bfad8c0cedc0b983db55 | |
| author | Richard Henderson <rth@twiddle.net> | |
| Thu, 5 Oct 2017 14:35:59 +0000 (5 10:35 -0400) | ||
| committer | Riku Voipio <riku.voipio@linaro.org> | |
| Mon, 16 Oct 2017 13:00:56 +0000 (16 16:00 +0300) | ||
| tree | 11bf3920f61db79d62eff37e85504e01afbe3c5f | treesnapshot (tar.gz zip) |
| parent | e568f9df086965813a318ff0558782ba90e59c33 | commitdiff |
tcg: Fix off-by-one in assert in page_set_flags
Most of the users of page_set_flags offset (page, page + len) as
the end points. One might consider this an error, since the other
users do supply an endpoint as the last byte of the region.
However, the first thing that page_set_flags does is round end UP
to the start of the next page. Which means computing page + len - 1
is in the end pointless. Therefore, accept this usage and do not
assert when given the exact size of the vm as the endpoint.
Signed-off-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20170708025030.15845-2-rth@twiddle.net>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Most of the users of page_set_flags offset (page, page + len) as
the end points. One might consider this an error, since the other
users do supply an endpoint as the last byte of the region.
However, the first thing that page_set_flags does is round end UP
to the start of the next page. Which means computing page + len - 1
is in the end pointless. Therefore, accept this usage and do not
assert when given the exact size of the vm as the endpoint.
Signed-off-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20170708025030.15845-2-rth@twiddle.net>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
| accel/tcg/translate-all.c | diffblobblamehistory |