sh4: simplify superh_cpu_class_by_name()
commitd5ebe625569365e83c104f7ef4bbeab282299407
authorIgor Mammedov <imammedo@redhat.com>
Thu, 5 Oct 2017 13:50:56 +0000 (5 15:50 +0200)
committerEduardo Habkost <ehabkost@redhat.com>
Fri, 27 Oct 2017 14:03:55 +0000 (27 16:03 +0200)
tree9ca6ca5f27852e69298f2bae0eabdcbc9629189c
parent974e58d2105f1b728232ce354441f95ff0349388
sh4: simplify superh_cpu_class_by_name()

currently for sh4 cpu_model argument for '-cpu' option
could be either 'cpu model' name or cpu_typename.

however typically '-cpu' takes 'cpu model' name and
cpu type for sh4 target isn't advertised publicly
('-cpu help' prints only 'cpu model' names) so we
shouldn't care about this use case (it's more of a bug).

1. Drop '-cpu cpu_typename' to align with the rest of
   targets.
2. Compose searched for typename from cpu model and use
   it with object_class_by_name() directly instead of
   over-complicated
       object_class_get_list()
       g_slist_find_custom() + superh_cpu_name_compare()

With #1 droped, #2 could be used for both lookups which
simplifies superh_cpu_class_by_name() quite a bit.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <1507211474-188400-23-git-send-email-imammedo@redhat.com>
[ehabkost: Include fixup sent by Igor]
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
linux-user/main.c
target/sh4/cpu.c