| commit | cb927b8aee7c3993a43cb829f7341071f873857b | |
| author | Christian Borntraeger <borntraeger@de.ibm.com> | |
| Thu, 30 Apr 2015 15:53:13 +0000 (30 17:53 +0200) | ||
| committer | Cornelia Huck <cornelia.huck@de.ibm.com> | |
| Fri, 8 May 2015 08:36:02 +0000 (8 10:36 +0200) | ||
| tree | a17a5bcd3ba44e3fb68b36063433ea2d7103e14d | treesnapshot (tar.gz zip) |
| parent | f8340b360b9bc29d48716ba8aca79df2b9544979 | commitdiff |
s390-virtio: Accommodate guests using virtqueues too early
Feature updates are not a synchronuous operation for the legacy
s390-virtio transport. This transport syncs the guest feature bits
(those from finalize) on the set_status hypercall. Before that qemu
thinks that features are zero, which means QEMU will misbehave, e.g.
it will not write the event index, even if the guest asks for it.
Let's detect the case where a kick happens before the driver is ready
and force sync the features.
With this workaround, it is now safe to switch to the common feature
bit handling code as used by all other transports.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Feature updates are not a synchronuous operation for the legacy
s390-virtio transport. This transport syncs the guest feature bits
(those from finalize) on the set_status hypercall. Before that qemu
thinks that features are zero, which means QEMU will misbehave, e.g.
it will not write the event index, even if the guest asks for it.
Let's detect the case where a kick happens before the driver is ready
and force sync the features.
With this workaround, it is now safe to switch to the common feature
bit handling code as used by all other transports.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
| hw/s390x/s390-virtio.c | diffblobblamehistory |