| commit | c88f68ec3ce54ebc5da13d07d6512689c4e9be30 | |
| author | Fam Zheng <famz@redhat.com> | |
| Mon, 12 Jan 2015 04:43:09 +0000 (12 12:43 +0800) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Wed, 14 Jan 2015 09:38:57 +0000 (14 10:38 +0100) | ||
| tree | ac05185a275c67540cac5f107104a6e9d7cad248 | treesnapshot (tar.gz zip) |
| parent | 6f84da3a07668ce881a0c853390eb05313d61157 | commitdiff |
rules.mak: Fix module build
Module build is broken since commit c261d774fb ( rules.mak: Fix DSO
build by pulling in archive symbols). That commit added .mo placeholders
of DSO to -y variables, in order to pull stub symbols to executable. But
the placeholders are unintentionally expanded in -y, rather than
filtered out while linking.
Fix it by moving the -objs expanding to before inserting .mo
placeholders. Note that passing -cflags and -libs to member objects are
also moved to keep it happening before object expanding.
Reported-by: Bharata B Rao <bharata.rao@gmail.com>
Tested-by: Bharata B Rao <bharata.rao@gmail.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Module build is broken since commit c261d774fb ( rules.mak: Fix DSO
build by pulling in archive symbols). That commit added .mo placeholders
of DSO to -y variables, in order to pull stub symbols to executable. But
the placeholders are unintentionally expanded in -y, rather than
filtered out while linking.
Fix it by moving the -objs expanding to before inserting .mo
placeholders. Note that passing -cflags and -libs to member objects are
also moved to keep it happening before object expanding.
Reported-by: Bharata B Rao <bharata.rao@gmail.com>
Tested-by: Bharata B Rao <bharata.rao@gmail.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| rules.mak | diffblobblamehistory |