hw: Replace anti-social QOM type names (again)
commitc455e011c61c91d152ac6170c2a3b7fbc89e194a
authorMarkus Armbruster <armbru@redhat.com>
Fri, 17 Nov 2023 11:44:54 +0000 (17 12:44 +0100)
committerThomas Huth <thuth@redhat.com>
Wed, 20 Dec 2023 09:29:23 +0000 (20 10:29 +0100)
tree19466bafd35e178575be8bfbbbcf5e101dd808b1
parentbce9bbc3c991a087130babc243a9f2c1e6bcf8a5
hw: Replace anti-social QOM type names (again)

QOM type names containing ',' result in awful UI.  We got rid of them
in v6.0.0 (commit e178113ff64 hw: Replace anti-social QOM type names).
A few have crept back since:

    xlnx,cframe-reg
    xlnx,efuse
    xlnx,pmc-efuse-cache
    xlnx,versal-cfu-apb
    xlnx,versal-cfu-fdro
    xlnx,versal-cfu-sfr
    xlnx,versal-crl
    xlnx,versal-efuse
    xlnx,zynqmp-efuse

These are all device types.  They can't be plugged with -device /
device_add, except for "xlnx,efuse" (I'm not sure that one is
intentional).

They *can* be used with -device / device_add to request help.
Usability is poor, though: you have to double the comma, like this:

    $ qemu-system-aarch64 -device xlnx,,pmc-efuse-cache,help

They can also be used with -global, where you must *not* double the
comma:

    $ qemu-system-aarch64 -global xlnx,efuse.drive-index=2

Trap for the unwary.

"xlnx,efuse", "xlnx,versal-efuse", "xlnx,pmc-efuse-cache",
"xlnx-zynqmp-efuse" are from v6.2.0, "xlnx,versal-crl" is from v7.1.0,
and the remainder are new.

Rename them all to "xlnx-FOO", like commit e178113ff64 did.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Francisco Iglesias <francisco.iglesias@amd.com>
Message-ID: <20231117114457.177308-3-thuth@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
docs/system/arm/xlnx-versal-virt.rst
include/hw/misc/xlnx-versal-cframe-reg.h
include/hw/misc/xlnx-versal-cfu.h
include/hw/misc/xlnx-versal-crl.h
include/hw/nvram/xlnx-efuse.h
include/hw/nvram/xlnx-versal-efuse.h
include/hw/nvram/xlnx-zynqmp-efuse.h