| commit | c0d67ade53a6db090a1c17676ffcdcf16052dfb4 | |
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | |
| Wed, 30 Sep 2020 16:49:40 +0000 (30 18:49 +0200) | ||
| committer | Eduardo Habkost <ehabkost@redhat.com> | |
| Tue, 6 Oct 2020 15:09:35 +0000 (6 11:09 -0400) | ||
| tree | 058fc8a255300f23831c57d4807b9fac37eb8ac6 | treesnapshot (tar.gz zip) |
| parent | d7c5b788295426c1ef48a9ffc3432c51220f69ba | commitdiff |
hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler
The MACAddr structure contains an array of uint8_t. Previously
if a value was out of the [0..255] range, it was silently casted
and no input validation was done.
Replace strtol() by qemu_strtol() -- so checkpatch.pl won't
complain if we move this code later -- and return EINVAL if the
input is invalid.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200930164949.1425294-3-philmd@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
The MACAddr structure contains an array of uint8_t. Previously
if a value was out of the [0..255] range, it was silently casted
and no input validation was done.
Replace strtol() by qemu_strtol() -- so checkpatch.pl won't
complain if we move this code later -- and return EINVAL if the
input is invalid.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200930164949.1425294-3-philmd@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
| hw/core/qdev-properties.c | diffblobblamehistory |