block: check return value of bdrv_open_child and drop error propagation
commitbc520249595845d387aa5b5e4eeeade673931a98
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Tue, 2 Feb 2021 12:49:45 +0000 (2 15:49 +0300)
committerEric Blake <eblake@redhat.com>
Mon, 8 Mar 2021 21:07:09 +0000 (8 15:07 -0600)
tree08a767dbc1d9af92903e043028eb0216c25d89cf
parentf174cd3350c5e97db000e7383be974c66046b8f5
block: check return value of bdrv_open_child and drop error propagation

This patch is generated by cocci script:

@@
symbol bdrv_open_child, errp, local_err;
expression file;
@@

  file = bdrv_open_child(...,
-                        &local_err
+                        errp
                        );
- if (local_err)
+ if (!file)
  {
      ...
-     error_propagate(errp, local_err);
      ...
  }

with command

spatch --sp-file x.cocci --macro-file scripts/cocci-macro-file.h \
--in-place --no-show-diff --max-width 80 --use-gitgrep block

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-Id: <20210202124956.63146-4-vsementsov@virtuozzo.com>
[eblake: fix qcow2_do_open() to use ERRP_GUARD, necessary as the only
caller to pass allow_none=true]
Signed-off-by: Eric Blake <eblake@redhat.com>
block/blkdebug.c
block/blklogwrites.c
block/blkreplay.c
block/blkverify.c
block/qcow2.c
block/quorum.c