| commit | b7b1e9dd6d56612d4656817b11e43d9fbefdc497 | |
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | |
| Thu, 27 Jul 2017 02:42:08 +0000 (26 23:42 -0300) | ||
| committer | Michael Tokarev <mjt@tls.msk.ru> | |
| Mon, 31 Jul 2017 10:06:38 +0000 (31 13:06 +0300) | ||
| tree | cc9ab18d6dc43054a04634c88826393c81ddbbff | treesnapshot (tar.gz zip) |
| parent | 2a4e2e4919d1fcb915f1b33f9396aad5dc4616f5 | commitdiff |
ivshmem: fix incorrect error handling in ivshmem_recv_msg()
Screwed up in commit 3a55fc0f, v2.6.0.
If qemu_chr_fe_read_all() returns -EINTR the do {} statement continues and the
n accumulator used to complete reads upto sizeof(msg) is decremented by 4 (the
value of EINTR on Linux).
To avoid that, use simpler if() statements and continue if EINTR occured.
hw/misc/ivshmem.c:650:14: warning: Loss of sign in implicit conversion
} while (n < sizeof(msg));
^
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Screwed up in commit 3a55fc0f, v2.6.0.
If qemu_chr_fe_read_all() returns -EINTR the do {} statement continues and the
n accumulator used to complete reads upto sizeof(msg) is decremented by 4 (the
value of EINTR on Linux).
To avoid that, use simpler if() statements and continue if EINTR occured.
hw/misc/ivshmem.c:650:14: warning: Loss of sign in implicit conversion
} while (n < sizeof(msg));
^
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| hw/misc/ivshmem.c | diffblobblamehistory |