util/vfio-helpers.c: Use ram_block_discard_disable() in qemu_vfio_open_pci()
commitb430b51395650137a80e78ee7395165b80fe1752
authorDavid Hildenbrand <david@redhat.com>
Mon, 16 Nov 2020 10:59:47 +0000 (16 11:59 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 16 Nov 2020 18:22:17 +0000 (16 13:22 -0500)
tree4857d2981dcaf46f1685610f075eb3e06603d5d8
parent2654ace151c07bd6519a7b71ab98d763137302eb
util/vfio-helpers.c: Use ram_block_discard_disable() in qemu_vfio_open_pci()

Currently, when using "nvme://" for a block device, like
    -drive file=nvme://0000:01:00.0/1,if=none,id=drive0 \
    -device virtio-blk,drive=drive0 \

VFIO may pin all guest memory, and discarding of RAM no longer works as
expected. I was able to reproduce this easily with my
    01:00.0 Non-Volatile memory controller: Samsung Electronics Co Ltd
            NVMe SSD Controller SM981/PM981/PM983

Similar to common VFIO, we have to disable it, making sure that:
a) virtio-balloon won't discard any memory ("silently disabled")
b) virtio-mem and nvme:// run mutually exclusive

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Peter Xu <peterx@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20201116105947.9194-1-david@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
stubs/ram-block.c
util/vfio-helpers.c