| commit | b1d80d12c5f7ff081bb80ab4f4241d4248691192 | |
| author | Jason Wang <jasowang@redhat.com> | |
| Wed, 30 May 2018 04:11:30 +0000 (30 12:11 +0800) | ||
| committer | Jason Wang <jasowang@redhat.com> | |
| Fri, 19 Oct 2018 03:15:04 +0000 (19 11:15 +0800) | ||
| tree | ff8cc6c725fce80c3d52a7534260c2b59ecc7057 | treesnapshot (tar.gz zip) |
| parent | 1a326646fef38782e5542280040ec3ea23e4a730 | commitdiff |
pcnet: fix possible buffer overflow
In pcnet_receive(), we try to assign size_ to size which converts from
size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access
for both buf and buf1.
Fixing by converting the type of size to size_t.
CC: qemu-stable@nongnu.org
Reported-by: Daniel Shapira <daniel@twistlock.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
In pcnet_receive(), we try to assign size_ to size which converts from
size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access
for both buf and buf1.
Fixing by converting the type of size to size_t.
CC: qemu-stable@nongnu.org
Reported-by: Daniel Shapira <daniel@twistlock.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
| hw/net/pcnet.c | diffblobblamehistory |