virtio-net: fix map leaking on error during receive
commitabe300d9d894f7138e1af7c8e9c88c04bfe98b37
authorJason Wang <jasowang@redhat.com>
Tue, 8 Mar 2022 02:42:51 +0000 (8 10:42 +0800)
committerJason Wang <jasowang@redhat.com>
Tue, 15 Mar 2022 05:57:44 +0000 (15 13:57 +0800)
tree28c9fda820a74f7b5f8aa26ed36c5003da2c2cd9
parent352998df1c53b366413690d95b35f76d0721ebed
virtio-net: fix map leaking on error during receive

Commit bedd7e93d0196 ("virtio-net: fix use after unmap/free for sg")
tries to fix the use after free of the sg by caching the virtqueue
elements in an array and unmap them at once after receiving the
packets, But it forgot to unmap the cached elements on error which
will lead to leaking of mapping and other unexpected results.

Fixing this by detaching the cached elements on error. This addresses
CVE-2022-26353.

Reported-by: Victor Tom <vv474172261@gmail.com>
Cc: qemu-stable@nongnu.org
Fixes: CVE-2022-26353
Fixes: bedd7e93d0196 ("virtio-net: fix use after unmap/free for sg")
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
hw/net/virtio-net.c