| commit | a0e640a87210b1e986bcd4e7f7de03beb3db0a4a | |
| author | Greg Kurz <groug@kaod.org> | |
| Sun, 26 Feb 2017 22:43:08 +0000 (26 23:43 +0100) | ||
| committer | Greg Kurz <groug@kaod.org> | |
| Tue, 28 Feb 2017 10:21:15 +0000 (28 11:21 +0100) | ||
| tree | 47fe2cc4eb1d19b7b63b6ebb7e67f5bf299868f8 | treesnapshot (tar.gz zip) |
| parent | df4938a6651b1f980018f9eaf86af43e6b9d7fed | commitdiff |
9pfs: local: remove: don't follow symlinks
The local_remove() callback is vulnerable to symlink attacks because it
calls:
(1) lstat() which follows symbolic links in all path elements but the
rightmost one
(2) remove() which follows symbolic links in all path elements but the
rightmost one
This patch converts local_remove() to rely on opendir_nofollow(),
fstatat(AT_SYMLINK_NOFOLLOW) to fix (1) and unlinkat() to fix (2).
This partly fixes CVE-2016-9602.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
The local_remove() callback is vulnerable to symlink attacks because it
calls:
(1) lstat() which follows symbolic links in all path elements but the
rightmost one
(2) remove() which follows symbolic links in all path elements but the
rightmost one
This patch converts local_remove() to rely on opendir_nofollow(),
fstatat(AT_SYMLINK_NOFOLLOW) to fix (1) and unlinkat() to fix (2).
This partly fixes CVE-2016-9602.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
| hw/9pfs/9p-local.c | diffblobblamehistory |