| commit | 97225170f6ee6d0ad8653916c7a5e4508cbffc18 | |
| author | Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> | |
| Mon, 11 Jan 2016 19:10:42 +0000 (11 14:10 -0500) | ||
| committer | John Snow <jsnow@redhat.com> | |
| Mon, 11 Jan 2016 19:10:42 +0000 (11 14:10 -0500) | ||
| tree | df7207c3f5e20598f4a972957d61ff2a04ee53b9 | treesnapshot (tar.gz zip) |
| parent | 7b8a354d4716ab2c201fad04c22b8d4a16a1b8c6 | commitdiff |
macio: fix overflow in lba to offset conversion for ATAPI devices
As the IDEState lba field is an int32_t, make sure we cast to int64_t before
shifting to calculate the offset. Otherwise we end up with an overflow when
trying to access sectors beyond 2GB as can occur when using DVD images.
[Maintainer edit: fixed extraneous parentheses. --js]
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-id: 1451928613-29476-1-git-send-email-mark.cave-ayland@ilande.co.uk
Signed-off-by: John Snow <jsnow@redhat.com>
As the IDEState lba field is an int32_t, make sure we cast to int64_t before
shifting to calculate the offset. Otherwise we end up with an overflow when
trying to access sectors beyond 2GB as can occur when using DVD images.
[Maintainer edit: fixed extraneous parentheses. --js]
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-id: 1451928613-29476-1-git-send-email-mark.cave-ayland@ilande.co.uk
Signed-off-by: John Snow <jsnow@redhat.com>
| hw/ide/macio.c | diffblobblamehistory |