fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()
commit91685323b142a655378b673bfcc5b424c77dfe1a
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Thu, 29 Jun 2017 14:07:15 +0000 (29 15:07 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 3 Jul 2017 19:29:49 +0000 (3 22:29 +0300)
tree8ad8ba8bff7e2ae246718cbf721a7cabf17e63f2
parentc0e9067902a35f4b5cc24b0bc84dbc5872e9cf86
fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

As indicated by Laszlo it is a QOM bug for the realize() method to actually
map the device. Set up the IO regions within fw_cfg_io_realize() and defer
the mapping with sysbus_add_io() to the caller, as already done in
fw_cfg_init_mem_wide().

This makes the iobase and dma_iobase properties now obsolete so they can be
removed.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Gabriel Somlo <somlo@cmu.edu>
hw/nvram/fw_cfg.c