hw/scsi/lsi53c895a: add missing decrement of reentrancy counter
commit8b09b7fe47082c69295a0fc0cc01b041b6385025
authorSven Schnelle <svens@stackframe.org>
Sun, 28 Jan 2024 20:22:14 +0000 (28 21:22 +0100)
committerThomas Huth <thuth@redhat.com>
Mon, 5 Feb 2024 13:21:21 +0000 (5 14:21 +0100)
tree0889c80fdd8f2ac1b9913e4037496abc014f9f38
parent39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440
hw/scsi/lsi53c895a: add missing decrement of reentrancy counter

When the maximum count of SCRIPTS instructions is reached, the code
stops execution and returns, but fails to decrement the reentrancy
counter. This effectively renders the SCSI controller unusable
because on next entry the reentrancy counter is still above the limit.

This bug was seen on HP-UX 10.20 which seems to trigger SCRIPTS
loops.

Fixes: b987718bbb ("hw/scsi/lsi53c895a: Fix reentrancy issues in the LSI controller (CVE-2023-0330)")
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Message-ID: <20240128202214.2644768-1-svens@stackframe.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Helge Deller <deller@gmx.de>
Signed-off-by: Thomas Huth <thuth@redhat.com>
hw/scsi/lsi53c895a.c