pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction
commit7cd50cbe4ca3e2860b31b06ec92c17c54bd82d48
authorThomas Huth <thuth@redhat.com>
Tue, 27 Jun 2023 07:47:03 +0000 (27 09:47 +0200)
committerThomas Huth <thuth@redhat.com>
Thu, 29 Jun 2023 18:45:12 +0000 (29 20:45 +0200)
tree4f00e324230460121af96e734ef10a9ba0657282
parente31f08dc748bad980f2092be165bd091f9cf3c48
pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction

start.S currently cannot be compiled with Clang 16 and binutils 2.40:

 ld: start.o(.text+0x8): misaligned symbol `__bss_start' (0xc1e5) for
     relocation R_390_PC32DBL

According to the built-in linker script of ld, the symbol __bss_start
can actually point *before* the .bss section and does not need to have
any alignment, so in certain situations (like when using the internal
assembler of Clang), the __bss_start symbol can indeed be unaligned
and thus it is not suitable for being used with the "larl" instruction
that needs an address that is at least aligned to halfwords.
The problem went unnoticed so far since binutils <= 2.39 did not
check the alignment, but starting with binutils 2.40, such unaligned
addresses are now refused.

Fix it by loading the address indirectly instead.

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2216662
Reported-by: Miroslav Rezanina <mrezanin@redhat.com>
Suggested-by: Andreas Krebbel <andreas.krebbel@de.ibm.com>
Message-Id: <20230629104821.194859-8-thuth@redhat.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
pc-bios/s390-ccw/start.S